Add source bundle upward Needs exports - #772
Draft
AlexanderLanin wants to merge 1 commit into
Draft
Conversation
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
Contributor
|
Documentation preview for this pull request is available at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
Every source-bearing
docs_bundlenow produces a reusable Needs JSON export. This makes each bundle independently consumable for traceability and allows a documentation hierarchy to pass its Needs upward from bundle to bundle.For a bundle without ancestors, the upward export is its own Needs JSON. For a bundle with ancestors, the upward export contains the bundle's own Needs plus the complete merged Needs of its ancestors.
Technical design
upward_bundlesas an explicit documentation-hierarchy dependency*_needs_localfrom a bundle's own sources while ancestor exports are available as external resolution context*_needs_upwardas the merged, reusable export for the next bundle in the hierarchyScope
Needs declared in generated bundle data are intentionally not included yet; this PR prepares source-bearing bundles. Data-only bundles do not create Needs targets, while source-less hierarchy groups can forward already-generated upward exports.